Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVSS PCIU Migration: Flipper flag and deploy to Prod/Stage #74590

Closed
7 tasks
Tracked by #73776
jennb33 opened this issue Jan 26, 2024 · 2 comments
Closed
7 tasks
Tracked by #73776

EVSS PCIU Migration: Flipper flag and deploy to Prod/Stage #74590

jennb33 opened this issue Jan 26, 2024 · 2 comments

Comments

@jennb33
Copy link
Contributor

jennb33 commented Jan 26, 2024

Issue Description

To prepare for the eventual sunsetting of EVSS, all calls to PCIU must eventually be removed from vets-api. During the course of discovery for Form526ez, it was discovered that calls to PCIU were being made in the FormProfile base-class related to the Pre-fill functionality- specifically to gather phone and email information. While Form526ez and many other forms intentionally use it in combination with their own derived Pre-fill classes, further digging through vets-api and in DataDog revealed that essentially every form in the system was calling out to PCIU. Either way, it became apparent that the scope of the problem was beyond just Form526ez.

The good news is that the base-class pre-fill is already calling out to VA Profile, which is widely considered the best one-stop source of all contact information within the VA. The specific reason we call out to PCIU here at all remains a mystery, although the best educated guess so far suggests that it may have to do with a potential lag between the time that the user enters/updates information and the time when it becomes available in VA Profile. In other words, if a user just updated their information and went straight to an application that uses Pre-fill, that information might not prefill in that application's form. This is just speculation, however, and there's a chance that if it WAS a problem when they added the PCIU calls 4-6 years ago, that latency might not be an issue anymore.


Tasks

  • Use a flipper flag to gate the removal of the base-class PCIU calls
  • Deploy to Production/Staging with the flipper flag off (for Prod) and on (for Staging)

Acceptance Criteria

  • Flipper Flag is used to gate the removal of the base-class PCIU calls

How to configure this issue

  • EVSS PCIU Migration: Remove calls to PCIU in global Pre-fill
  • Product Support
  • backend, devops
  • request
@jennb33 jennb33 added needs-grooming Use this to designate any issues that need grooming from the team PCIU labels Feb 8, 2024
@jennb33 jennb33 removed the needs-grooming Use this to designate any issues that need grooming from the team label Feb 22, 2024
@RachalCassity
Copy link
Member

This will be handled by the Benefits team and not related to the Platform Product Team

@jennb33
Copy link
Contributor Author

jennb33 commented Mar 21, 2024

Closing this ticket because it is not Platform Product work, per @RachalCassity's note above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants