Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEDUHSF Fixes -Re-encode uploaded TXT files whose content is not valid UTF-8/ANSI #78251

Open
freeheeling opened this issue Mar 12, 2024 · 1 comment
Labels
code-yellow Related to an ongoing Code Yellow issue DBEX-Carbs Disability Benefits Experience - Team Carbs disability-experience

Comments

@freeheeling
Copy link
Contributor

freeheeling commented Mar 12, 2024

Follow-on work from Document Supporting Documentation File Upload Validations #75347 investigation

A validation failure that happens to occur with great frequency is invalid file text encoding. It merits verifying whether or not uploaded TXT files are UTF-8/ANSI encoded as part of the validation process, given that these encompass the majority of error response types returned by EVSS. Some options to address this encoding issue are mentioned here. It may be necessary to re-encode uploaded TXT files if their content is not valid UTF-8/ANSI, before storing them to S3.

@freeheeling freeheeling added the DBEX-Carbs Disability Benefits Experience - Team Carbs label Mar 12, 2024
@freeheeling freeheeling changed the title Re-encode uploaded TXT files Re-encode uploaded TXT files whose content is not valid UTF-8/ANSI Mar 12, 2024
@ajones446 ajones446 self-assigned this Aug 14, 2024
@lisacapaccioli lisacapaccioli added the code-yellow Related to an ongoing Code Yellow issue label Aug 23, 2024
@ajones446
Copy link
Contributor

Update from August 20 meeting: we decided not to re-encode uploaded TXT files if their content is not valid. We should try to validate encoding before storing to S3 and display an error message before the user submits the form.

@lisacapaccioli lisacapaccioli changed the title Re-encode uploaded TXT files whose content is not valid UTF-8/ANSI VEDUHSF Fixes -Re-encode uploaded TXT files whose content is not valid UTF-8/ANSI Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-yellow Related to an ongoing Code Yellow issue DBEX-Carbs Disability Benefits Experience - Team Carbs disability-experience
Projects
None yet
Development

No branches or pull requests

3 participants