Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging Review finding: Remove additional info component in alert #88442

Open
3 tasks
shiragoodman opened this issue Jul 16, 2024 · 6 comments
Open
3 tasks

Staging Review finding: Remove additional info component in alert #88442

shiragoodman opened this issue Jul 16, 2024 · 6 comments
Assignees
Labels
appointments-fe-ux VAOS Product & Design team tag. Do not use for engineering work. appointments-pm VAOS Product Management CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS consistency VA.gov Experience standard category: Consistency design exp-std-design-consistency VA.gov Experience Standard: User encounters design components that are inconsistent or confusing. Staging va-additional-info

Comments

@shiragoodman
Copy link
Contributor

shiragoodman commented Jul 16, 2024

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Appointments
Product: Appointments
Feature: Appointment Details Redesign

Findings details

VA.gov Experience Standard - issue: User encounters design components or patterns that are inconsistent or confusing.
VA.gov Experience Standard - category: Consistency
Launch-blocking: No
Design System review: No
Collab Cycle Reviewer: @allison0034 (Design)

Description

The alert currently contains an additional info component inside of it. Per our guidance, alerts should not contain other expandable components such as the Additional info component.

Link, screenshot or steps to recreate

Screen shot

Recommended action

Remove the additional info component and place content directly inside the alert.

References

  • Accessibility Defect Severity: N/A
  • WCAG Success Criteria: N/A
  • Modality: N/A
  • Design System Component: Additional info
  • Design System Pattern or Template: N/A
  • Design System Foundation: N/A
  • Content Style Guide: N/A
  • Context: N/A

Next Steps for the VFS Team

  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
  • Ticket ownership: If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag @platform-governance-team-members on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.
  • Close this ticket when the issue has been resolved or validated by your Product Owner.
@shiragoodman shiragoodman added appointments VA Online Scheduling tool product tag appointments-pm VAOS Product Management CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS consistency VA.gov Experience standard category: Consistency design exp-std-design-consistency VA.gov Experience Standard: User encounters design components that are inconsistent or confusing. Staging va-additional-info labels Jul 16, 2024
@ldelacosta
Copy link
Contributor

@outerpress - let me know who should we talk to about this.

@outerpress
Copy link
Contributor

@laurwill I think you did a bunch of work to align these across teams - thoughts? FYI also @kristenmcconnell @kfink24

(I'd pull Joel Calumpong in too bug can't find his GH handle)

@outerpress outerpress self-assigned this Jul 19, 2024
@outerpress outerpress added the appointments-fe-ux VAOS Product & Design team tag. Do not use for engineering work. label Jul 19, 2024
@kfink24
Copy link
Contributor

kfink24 commented Jul 19, 2024

I'm not sure what team owns the design of the alert, I think it may be cartographers cc: @sterkenburgsara @jonathanjnelson

Also adding Lexi since we now have it on Meds as well and since I can't tag Joel either. cc: @alexiawunder

@ldelacosta ldelacosta removed the appointments VA Online Scheduling tool product tag label Aug 15, 2024
@outerpress
Copy link
Contributor

Added a design ticket to handle this on the appts side, #93262. We'll coordinate with other health apps teams to make sure we're aligned.

@sterkenburgsara
Copy link
Contributor

cc @underpaid1ntern

@sterkenburgsara
Copy link
Contributor

Cartography doesn't own this alert, but it's a good health-portal-wide flag! Go team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appointments-fe-ux VAOS Product & Design team tag. Do not use for engineering work. appointments-pm VAOS Product Management CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS consistency VA.gov Experience standard category: Consistency design exp-std-design-consistency VA.gov Experience Standard: User encounters design components that are inconsistent or confusing. Staging va-additional-info
Projects
None yet
Development

No branches or pull requests

5 participants