Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup rep and org info for next steps email #96351

Closed
5 tasks done
opticbob opened this issue Nov 1, 2024 · 5 comments
Closed
5 tasks done

Lookup rep and org info for next steps email #96351

opticbob opened this issue Nov 1, 2024 · 5 comments
Assignees
Labels
accredited-representation-management-team Accredited Representation Management team backend mvp Initial version of thing

Comments

@opticbob
Copy link

opticbob commented Nov 1, 2024

Background

There are some validation issues with the interplay between the frontend and the backend for the next steps email endpoint. We are going to move from sending a rep name, address, and type to sending a entity_type and entity_id so those values can be looked up on the backend. This will make it easier to cover both selections of individuals and orgs as a whole.

Tasks

  • Remove representative_address, _name, and _type fields.
  • Add entity_type that should be validated to be individual or organization.
  • Add entity_id.
  • Use those two new fields to lookup the entities from both the legacy and accredited tables like we do in the PDF data objects.

Acceptance Criteria

  • Frontend payloads that match the changes above will send the next steps email from VA Notify and return a 200 status.

How to configure this issue

  1. Label with practice area (backend, frontend,ux, design, research)
  2. Label for MVP work? (mvp)
  3. Add an estimate
  4. Attach an Epic (what body of work is this a part of?)
@opticbob
Copy link
Author

opticbob commented Nov 4, 2024

I'm working on fixing the last test and the PR for this will be ready for review. I anticipate that happening early tomorrow morning.

@opticbob
Copy link
Author

opticbob commented Nov 5, 2024

@holdenhinkle Has approved the PR for this. If platform hasn't approved it by 11:15 CST tomorrow I'll ping them.

@opticbob
Copy link
Author

opticbob commented Nov 6, 2024

I pinged Platform today and was informed that their policy is currently to have developers wait 3 business days after their teammates approval before requesting a PR review.

@opticbob
Copy link
Author

opticbob commented Nov 8, 2024

Platform has commented on the PR but hasn't responded to further comments.

@opticbob
Copy link
Author

This was approved by platform this morning and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-representation-management-team Accredited Representation Management team backend mvp Initial version of thing
Projects
None yet
Development

No branches or pull requests

2 participants