Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data payload for next steps email endpoint #96353

Closed
4 of 5 tasks
opticbob opened this issue Nov 1, 2024 · 1 comment · Fixed by department-of-veterans-affairs/vets-website#32886
Closed
4 of 5 tasks
Assignees
Labels
accredited-representation-management-team Accredited Representation Management team frontend mvp Initial version of thing

Comments

@opticbob
Copy link

opticbob commented Nov 1, 2024

Background

There are some validation issues with the interplay between the frontend and the backend for the next steps email endpoint. We are going to move from sending a rep name, address, and type to sending a entity_type and entity_id so those values can be looked up on the backend. This will make it easier to cover both selections of individuals and orgs as a whole. The frontend also needs to send the email_address field.

Tasks

  • Remove representative_address, _name, and _type fields.
  • Add entity_type that should be validated to be individual or organization.
  • Add entity_id.
  • Add email_address. If there is a claimant email it should be that one, if not we should use the veteran's email.

Acceptance Criteria

  • The frontend will generate a payload that return a 200 status from the backend.

How to configure this issue

  1. Label with practice area (backend, frontend,ux, design, research)
  2. Label for MVP work? (mvp)
  3. Add an estimate
  4. Attach an Epic (what body of work is this a part of?)
@holdenhinkle
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-representation-management-team Accredited Representation Management team frontend mvp Initial version of thing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants