Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links to My VA Health from DS location page #96902

Closed
4 tasks
outerpress opened this issue Nov 12, 2024 · 19 comments
Closed
4 tasks

Remove links to My VA Health from DS location page #96902

outerpress opened this issue Nov 12, 2024 · 19 comments
Assignees
Labels
appointments VA Online Scheduling tool product tag frontend

Comments

@outerpress
Copy link
Contributor

outerpress commented Nov 12, 2024

Description

Remove the Schedule online at My VA Health links from the choose a location page in the DS flow.

The user will still be able to navigate to My VA Health by selecting a location, which leads to a page with a link to My VA Health and contact information. See the user flows for details.

This is a section 508 high severity defect. See this thread for more information.

Screenshot of affected page:

Image


Development Checklist

  • Task 1
  • Task 2

Design Assets

N/A

Developer Reference

Definition of Done

@outerpress outerpress added appointments VA Online Scheduling tool product tag frontend needs-grooming Use this to designate any issues that need grooming from the team labels Nov 12, 2024
@outerpress
Copy link
Contributor Author

@JRRoof fyi this is to resolve the Section 508 High Severity defect @rileyorr reported in this thread

Also fyi @ryanshaw since you worked on something similar for OH scheduling

@ryanshaw
Copy link
Contributor

ryanshaw commented Nov 12, 2024

Just documenting some research I did on staging regarding two test users:

TLDR; it looks like if a patient is not eligible for scheduling at a given facility they get the warning modal, but if they are and it's a OH facility they get the location page with a link to My VA Health (at least on staging).

The facilities with the links are OH/Cerner facilities. The ones without are VistA facilities. Below you can see that Judy is ruled as ineligible for scheduling at Bonner County and so that warning modal pops up. However, Cecil/royal is eligible at what is a VistA facility and get the the location page with a link to My VA Health.

judy.morrison@id.me : Primary Care / Bonner County ID VA

{
    "data": {
        "id": "e7b2",
        "type": "patient_metadata",
        "attributes": {
            "decisionDate": "2024-11-12T21:40:27.244446552Z",
            "clinicalServiceId": "primaryCare",
            "type": "request",
            "eligible": false,
            "ineligibilityReasons": [
                {
                    "coding": [
                        {
                            "code": "patient-not-found",
                            "display": "no record for the given ICN was found in cerner"
                        }
                    ]
                }
            ],
            "id": "e7b2"
        }
    }
}

royal.tester@id.me : Primary Care / Loveland VA

{
    "data": {
        "id": "4347",
        "type": "patient_metadata",
        "attributes": {
            "clinicalServiceId": "primaryCare",
            "type": "request",
            "eligible": true,
            "id": "4347"
        }
    }
}

@Bren22va Bren22va removed the needs-grooming Use this to designate any issues that need grooming from the team label Nov 13, 2024
@ryanshaw ryanshaw self-assigned this Dec 11, 2024
@ryanshaw
Copy link
Contributor

Picking this up as I did the original work

@ryanshaw
Copy link
Contributor

@outerpress This is ready to validate once deployed to staging, I just merged it.

@outerpress
Copy link
Contributor Author

@ryanshaw I'm running into an issue. When I select an OH clinic, I expect this page:

Image

Instead I'm getting this alert:

Image

@ryanshaw
Copy link
Contributor

@ryanshaw I'm running into an issue. When I select an OH clinic, I expect this page:

Image

Instead I'm getting this alert:

Image

@outerpress Gotcha. I'll investigate the flow, I thought it was just removing those links.

@outerpress
Copy link
Contributor Author

@ryanshaw it might be a Judy issue. I just checked royal.tester@id.me and the correct page is showing when I pick Mann-Grandstaff

Image

@ryanshaw
Copy link
Contributor

@outerpress Yes, I think so but will verify. See my first comment on the issue. I don't think Judy is eligible?

@ryanshaw
Copy link
Contributor

@outerpress For Judy on staging, when selecting PrimaryCare I get this back:

{
    "data": {
        "id": "PrimaryCare",
        "type": "cc_eligibility",
        "attributes": {
            "eligible": false
        }
    }
}

I then select Coeur d'Alene and get this back:

{
    "data": {
        "id": "c6ef",
        "type": "patient_metadata",
        "attributes": {
            "decisionDate": "2024-12-12T19:34:46.613409285Z",
            "clinicalServiceId": "primaryCare",
            "type": "request",
            "eligible": true,
            "id": "c6ef"
        }
    }
}

Is Judy only eligible for CC for that type of care?

@outerpress
Copy link
Contributor Author

Oh interesting. I thought we send users to the My VA Health page regardless of the facility settings since you basically have to contact the facility to schedule (at least until we're done with OH scheduling work).

Actually when I choose Coeur d'Alene with Judy I get the same "This facility doesn't accept online scheduling for this care" error message. Is that what you were expecting?

@ryanshaw
Copy link
Contributor

@outerpress I'll need to investigate the eligibility checks. What I was expecting, was it was just the links that needed to be removed but we may have to adjust flow too, depending on the eligibility checks. I will move this back to in progress for now.

@ryanshaw
Copy link
Contributor

ryanshaw commented Dec 12, 2024

@outerpress I forgot that on staging we have a bunch of debug info that is dumped to the developer tools console around eligibility. This is what is returned for Judy / Primary Care / Coeur d'Alene VA:

Image

This may be a question of determining which staging user is set up correctly for testing this. I can work on finding one.

I am also noticing with Cecil above that the eligibility check is not happening and the redirect is going to the How to schedule screen without checking for eligibility.

Strike that. Looks like the eligibility endpoint is now returning 404 and there are some other issues I'm running into on staging...

@outerpress
Copy link
Contributor Author

@ryanshaw I found this note in the requirements for the My VA Health redirect page:

If a user chose a Cerner facility on the facility choice page, no eligibility checks are performed and they're sent to this page.

I don't remember the requirements changing (though it's def possible). Can you tell if the code changed at some point to add the eligibility check for OH facilities?

@ryanshaw
Copy link
Contributor

@outerpress Sorry, I was unclear. When I select Primary Care for Cecil I get a 404 response from the eligibility endpoint. When I select Primary Care for Judy I get this response:

{
    "data": {
        "id": "PrimaryCare",
        "type": "cc_eligibility",
        "attributes": {
            "eligible": false
        }
    }
}

@ryanshaw
Copy link
Contributor

ryanshaw commented Dec 12, 2024

This is just to document what is happening on staging with Judy and Cecil:

judy.morrison@id.me

  • Type of Care: Primary Care (323)
  • Facility: Coeur d 'Alene VA Clinic (668GB)

Facility Configuration returns:

{
    "id": "primaryCare",
    "name": "Primary Care",
    "stopCodes": [
        {
            "primary": "322",
            "defaultForRequests": false
        },
        {
            "primary": "323",
            "defaultForRequests": false
        },
        {
            "primary": "350",
            "defaultForRequests": false
        }
    ],
    "direct": {
        "patientHistoryRequired": false,
        "patientHistoryDuration": 0,
        "canCancel": true,
        "enabled": false
    },
    "request": {
        "patientHistoryRequired": false,
        "patientHistoryDuration": 0,
        "canCancel": true,
        "submittedRequestLimit": 1,
        "enterpriseSubmittedRequestLimit": 1,
        "enabled": false
    }
},

Eligibility check returns:

    eligibility: {
      '668GB_323': {
        direct: false,
        directReasons: [
          'notSupported'
        ],
        request: false,
        requestReasons: [
          'notSupported'
        ]
      }
    },
    eligibilityStatus: 'succeeded',
    isCCEligible: false,

Result: Shown the this facility does not accept online scheduling for this type of care modal


royal.tester@Id.me (Cecil)

  • Type of Care: Primary Care (323)
  • Facility: Mann-Grandstaff Department of Veterans Affairs Medical Center (668)

Facility Configuration returns:

{
    "id": "primaryCare",
    "name": "Primary Care",
    "stopCodes": [
        {
            "primary": "322",
            "defaultForRequests": false
        },
        {
            "primary": "323",
            "defaultForRequests": false
        },
        {
            "primary": "350",
            "defaultForRequests": false
        }
    ],
    "direct": {
        "patientHistoryRequired": false,
        "patientHistoryDuration": 0,
        "canCancel": true,
        "enabled": false
    },
    "request": {
        "patientHistoryRequired": false,
        "patientHistoryDuration": 0,
        "canCancel": true,
        "submittedRequestLimit": 1,
        "enterpriseSubmittedRequestLimit": 1,
        "enabled": false
    }
},

Eligibility check returns:

    eligibility: {}
    eligibilityStatus: 'notStarted',
    isCCEligible: false,

The https://staging-api.va.gov/vaos/v2/community_care/eligibility/PrimaryCare request returns:

[
    {
        "title": "Not Found",
        "detail": "The resource could not be found",
        "code": "VAOS_404",
        "source": {
            "vamfUrl": "https://fwdproxy-staging.vfs.va.gov:4463/cce/v1/patients/146b5d330362e887f19a31ab2d85cc3e0e2a8b5428afc750528cbe0b3764f585/eligibility/PrimaryCare",
            "vamfBody": "{\"timestamp\":1734047882956,\"type\":\"UnknownPatientIcnException\",\"message\":\"Unknown patient ICN: 1013678363V916823\"}",
            "vamfStatus": 404
        },
        "status": "404"
    }
]

The https://staging-api.va.gov/vaos/v2/eligibility?facility_id=668GB&clinical_service_id=primaryCare&type=request endpoint is never called.

Result: Shown the how to schedule page

@ryanshaw
Copy link
Contributor

@outerpress @JRRoof Moving this to external dependencies as it seems we cannot validate on staging yet, without a some OH configuration changes.

I will look into changing local mocks in a way so that we can validate locally on dev machines.

@ryanshaw
Copy link
Contributor

@outerpress and I were able to validate this, so closing.

@outerpress
Copy link
Contributor Author

FYI @rileyorr @kristenmcconnell @JRRoof this resolves the 508 defect, Riley feel free to review and let me know if you run into issues. (Judy is having trouble, so use royal.tester as your test user).

@rileyorr
Copy link
Contributor

@outerpress thank you! I tested the changes out in staging and everything looks great. I sent an update to Martha that this issue has been resolved so she can relay that to the Section 508 office. I appreciate y'all working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appointments VA Online Scheduling tool product tag frontend
Projects
None yet
Development

No branches or pull requests

5 participants