Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCIU Replacement Step 4b: Replace PCIU calls #98901

Open
6 tasks
Tracked by #73776
RachalCassity opened this issue Dec 11, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-api#18729
Open
6 tasks
Tracked by #73776

PCIU Replacement Step 4b: Replace PCIU calls #98901

RachalCassity opened this issue Dec 11, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-api#18729
Assignees
Labels

Comments

@RachalCassity
Copy link
Member

RachalCassity commented Dec 11, 2024

Summary

FormData.initialize_contact_information prefills contact information with PCIU data.
Coverband is showing a lot of data. This will have to be tested when migrating to VAProfile. PCIU references, extract_pciu_data, need to be removed. Draft pull request can be found here.

Ex:

Previous:

  def initialize_contact_information
    opt = {}
    opt.merge!(vets360_contact_info_hash) if vet360_contact_info
    opt[:address] ||= user_address_hash
    opt[:email] ||= extract_pciu_data(:pciu_email)
    if opt[:home_phone].nil?
      opt[:home_phone] = pciu_primary_phone
      opt[:us_phone] = pciu_us_phone
    end
    format_for_schema_compatibility(opt)
    FormContactInformation.new(opt)
  end

Next Steps

VFS teams can test their form pre-fills.

Tasks

  • Ensure initialize_contact_information is returning vet360_contact_info, no longer pciu data
  • Remove initialize_contact_information PCIU calls
  • Ensure all pre-fill form data is using vet360_contact_info data.
  • Ensure forms data is being properly loaded by testing in a local environment.
  • Ensure forms data is being properly loaded by testing in the staging environment.

Acceptance Criteria

  • VAProfile Contact Information V2 has successfully replaced the EVSS PCIU service for form pre-fill user data.
@RachalCassity RachalCassity changed the title Replace PCIU requests with VAProfile Contact Information Service Prefill data with VAProfile data instead of the PCIU data Dec 11, 2024
@RachalCassity RachalCassity changed the title Prefill data with VAProfile data instead of the PCIU data PCIU Replacement Step 4b: Prefill data with VAProfile data instead of the PCIU data Dec 11, 2024
@AshleyGuerrant AshleyGuerrant added PCIU needs-refinement Identifies tickets that need to be refined labels Dec 12, 2024
@RachalCassity RachalCassity changed the title PCIU Replacement Step 4b: Prefill data with VAProfile data instead of the PCIU data PCIU Replacement Step 6 (b): Remove PCIU configuration Dec 17, 2024
@RachalCassity RachalCassity changed the title PCIU Replacement Step 6 (b): Remove PCIU configuration PCIU Replacement Step 4 (b): Remove PCIU configuration Dec 18, 2024
@RachalCassity RachalCassity changed the title PCIU Replacement Step 4 (b): Remove PCIU configuration PCIU Replacement Step 6 (b): Remove PCIU configuration Dec 18, 2024
@RachalCassity RachalCassity changed the title PCIU Replacement Step 6 (b): Remove PCIU configuration PCIU Replacement Step 4 (b): Replace PCIU calls Dec 18, 2024
@AshleyGuerrant AshleyGuerrant changed the title PCIU Replacement Step 4 (b): Replace PCIU calls PCIU Replacement Step 4b: Replace PCIU calls Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants