[FSR] - Fix Employment Work Date Validation for Mobile

[OptionSelect]

Issue Description

Employment work dates does not validate correctly on mobile browsers preventing users from continuing through the form workflow.

Tasks

• I have reviewed the code changes and they align with the ticket's acceptance criteria.
• I have pulled the branch and manually tested the changes (if applicable).
• The changes do not introduce any new linting warnings or security vulnerabilities.
• Any new or updated tests are passing.

Design and Front End sync on implementation of design

• Required
• Complete
• Not Required

Acceptance Criteria

• Item one from the description performs as described in the description
• Item two from the description performs as described in the description

Testing

• N/A if non development work
• Testing passed and documented in this ticket based off the "Then" statement in the description

Test procedures:
If additional testing steps or credentials to perform testing are needed list them here

Ticket Creation - Definition of Ready

Ticket requirements

• Description written
• Tasks defined
• Acceptance criteria written
• Testing defined
• Add Labels
• Assign Type
• Assign Priority (Normal = Medium)
• Assign Group(s)
• Assign to a Project
• Attach to an Parent Epic
• Estimate Points

[Tom-Davis]

@OptionSelect please update the type and attributes below that in leu of labels. We also need to use the standard team template and hold this in "ready backlog" - we want to start assessing what might need to come out if we pull in mid sprint work.

@dhill802

[amponce]

Adding myself to this ticket, to assist with the debugging

[amponce]

We’ve identified the issue as an isolated mobile bug, likely caused by the recent update from moment to date-fns. Unfortunately, due to contract limitations, we don’t have enough time to resolve, test, and deploy the fix.

[amponce]

PR is up department-of-veterans-affairs/vets-website#33753

[amponce]

Here’s how we replicated the bug locally. On the employment dates page, we entered an incomplete date like ‘January 202’ and hit submit, which triggered the error message: ‘Please enter a valid employment start date.’ After adding the missing ‘1’ to make it ‘January 2021’ and hitting submit again, the error still persisted. Only after deleting and re-entering the ‘1’ were we able to proceed.

Our suspicion is that, specifically on mobile, validation might have been triggered too early while the user was still typing, leaving the field in a ‘dirty’ state and preventing progress. While it’s tricky to verify locally, we’ll confirm the fix on stage to ensure it’s resolved.