Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Standards - vfs-mhv-medical-records - MHV Medical Records/View Radiology Images/Settings #99361

Closed
7 of 16 tasks
it-harrison opened this issue Dec 18, 2024 · 6 comments
Closed
7 of 16 tasks
Assignees
Labels
collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS launch-blocking launch blocking issue found in Collab Cycle mhv-medical-records mhv-va.gov-medical-records QA qa-standards Quality Assurance Standards associated work items Staging

Comments

@it-harrison
Copy link
Contributor

General Information

VFS team name

vfs-mhv-medical-records

VFS product name

MHV Medical Records

VFS feature name

Download Records Phase 1

Point of Contact/Reviewers

@it-harrison - Ian Harrison - QA


QA Standards

Regression Test Plan

  • Standard has been met
  • Standard has not been met
Explanation of failure to meet standard (if applicable):

No Regression Plan among QA artifacts.

Test Plan

  • Standard has been met
  • Standard has not been met
Explanation of failure to meet standard (if applicable):

No Test Plan among QA artifacts

Traceability Reports

  • Standard has been met
  • Standard has not been met
Explanation of failure to meet standard (if applicable):

Due to restricted access, I have not been able to evaluate these artifacts

E2E Test Participation

  • Standard has been met
  • Standard has not been met
Explanation of failure to meet standard (if applicable):

Unit Test Coverage

  • Lines %: 89.59

  • Functions %: 82.26

  • Statements %: 89.82

  • Branches %: 79.14

  • Standard has been met

  • Standard has not been met

Explanation of failure to meet standard (if applicable):

All categories must be at least 80%; Branches is almost there!

Endpoint Monitoring (Completed Playbook)

  • Standard has been met
  • Standard has not been met
Explanation of failure to meet standard (if applicable):

Logging Silent Failures

  • Standard has been met
  • Standard has not been met
Explanation of failure to meet standard (if applicable):

To satisfy this requirement, we need to see where in code calls to StatsD are made such that any operation susceptible to a silent failure is accounted for. Check out this doc for more information.


Next Steps for the VFS team

  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
  • Close the ticket when your Product Owner determines that you have sufficiently met the QA Standards.

Platform directions

  • Update "Issue Title" to be of the form "QA Standards - VFS Team - VFS Product"
  • Add the VFS team, product name, and feature name
  • Add your name, practice area, and GH handle under Point of Contact/Reviewers
  • Complete the QA Standards section, making sure to include an "Explanation of failure to meet standard" for every Standard the product does not meet.
  • Link to the Collaboration Cycle Request epic
  • Add epic's milestone
  • Add assignees:
    • VFS PM
    • Yourself (optional)
  • Add labels:
    • VFS team label
    • VFS product label
    • QA-standards label
    • launch-blocking label if the product has failed to meet a required QA Standard
@it-harrison it-harrison added collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS launch-blocking launch blocking issue found in Collab Cycle mhv-medical-records mhv-va.gov-medical-records QA qa-standards Quality Assurance Standards associated work items Staging labels Dec 18, 2024
@bryan-riley-va
Copy link
Contributor

Phase 1 Work_GH.xlsx

Here's a static file for 'Traceability' showing coverage in the far right column. The Live file doesn't seem to allow me to share globally.

@bryan-riley-va
Copy link
Contributor

Dev team is working on getting branches up over 80%

@mmoyer-va
Copy link
Contributor

Regarding silent failures, these should not occur from the interactions in our application. There are 2 ways in which a veteran can submit data to the backend in MR:

  1. Change VHIE Sharing Setting - This is a synchronous operation, and the veteran receives immediate feedback in the form of a success or failure notification.
  2. Request Images from CVIX - The overall request is asynchronous, but the veteran can see the progress of the request via a polling progress bar. If any step of the process fails, (either the transfer from CVIX or any API call, including the progress check itself) an error message is displayed on the screen.

@bryan-riley-va
Copy link
Contributor

Unit testing above 80% as of this moment:

Image

@bryan-riley-va
Copy link
Contributor

Test plan link is here (had issues getting it moved so a new one was created): https://dsvavsp.testrail.io/index.php?/plans/view/6300

@bryan-riley-va
Copy link
Contributor

Closing this ticket as I believe we have resolved the previous launch blocking issues - @it-harrison please feel free to review or reopen if anything is still missing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS launch-blocking launch blocking issue found in Collab Cycle mhv-medical-records mhv-va.gov-medical-records QA qa-standards Quality Assurance Standards associated work items Staging
Projects
None yet
Development

No branches or pull requests

3 participants