Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging Review finding: Required fields must be marked as required #99392

Open
3 tasks
shiragoodman opened this issue Dec 18, 2024 · 0 comments
Open
3 tasks
Assignees
Labels
a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension exp-std-task-completion mhv-medical-records mhv-va.gov-medical-records Staging

Comments

@shiragoodman
Copy link
Contributor

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

This ticket was part of a merged Staging Review with MHV Medical Records Download Records, Flow/Images and Settings

Product Information

Team: vfs-mhv-medical-records
Product: MHV Medical Records
Feature: Phase 1 Radiology Flow/Images, Download Records, and Settings

Findings details

VA.gov Experience Standard - issue: User doesn't have enough information to complete a task.
VA.gov Experience Standard - category: Comprehension
Launch-blocking: No
Design System review: No
Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

In the form flow for downloading the Blue Button report, there are fields that require a response (and will trigger an error if left blank), but are not marked as required.

There are differing opinions in the accessibility world on "mark required fields" versus "mark optional fields" as a form design philosophy --- but the VA Design System comes down on the "mark required fields" side:

Properly indicate required form elements (the right thing will happen for you when you use the required property on form fields in the Design System).

Link, screenshot or steps to recreate

Select date range screen with Date range select input. There is no label to indicate any required inputs.

Recommended action

Mark each required field as required using the required prop on each form component.

References

  • Accessibility Defect Severity: 2: High. Should be fixed in 1-2 sprints post-launch.
  • WCAG Success Criteria: N/A
  • Modality: N/A
  • Design System Component: N/A
  • Design System Pattern or Template: N/A
  • Design System Foundation: N/A
  • Content Style Guide: N/A
  • Context: N/A

Next Steps for the VFS Team

  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
  • Ticket ownership: If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag @platform-governance-team-members on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.
  • Close this ticket when the issue has been resolved or validated by your Product Owner.
@shiragoodman shiragoodman added a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension exp-std-task-completion mhv-medical-records mhv-va.gov-medical-records Staging labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension exp-std-task-completion mhv-medical-records mhv-va.gov-medical-records Staging
Projects
None yet
Development

No branches or pull requests

2 participants