Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clinics on stop code exclusion list are being shown for scheduling when they shouldn't be #99448

Open
2 tasks
JRRoof opened this issue Dec 18, 2024 · 1 comment
Open
2 tasks
Assignees
Labels
appointments VA Online Scheduling tool product tag backend bug Something isn't working

Comments

@JRRoof
Copy link
Contributor

JRRoof commented Dec 18, 2024

Summary

When direct scheduling through the VAOS web app, clinics that should be excluded from scheduling are being presented as available for scheduling. Need to verify that vets-api is calling the VAOS service in order to retrieve clinics. Also, verify that the proper parameters are being passed, i.e. enableStopCodeFilter=true

##Details
Direct Scheduling Exclusion List: filter clinics with these primary and /or secondary stop code from direct scheduling. VAOS filters clinics for direct scheduling based on stop code exclusion list. https://coderepo.mobilehealth.va.gov/projects/VAR/repos/vaos-service/browse/vaos-service/src/main/resources/application.properties#19

mobile.vaos.clinicStopcodeExclusionList=${CLINIC_STOPCODE_EXCLUSION_LIST:[{"secondary":117},{"secondary":135},{"secondary":136},{"secondary":137},{"secondary":162},{"secondary":179},{"secondary":183},{"secondary":184},{"secondary":185},{"secondary":186},{"secondary":187},{"secondary":188},{"secondary":189},{"secondary":370},{"secondary":371},{"secondary":440},{"secondary":443},{"secondary":444},{"secondary":445},{"secondary":446},{"secondary":447},{"secondary":490},{"secondary":491},{"secondary":497},{"secondary":498},{"secondary":644},{"secondary":645},{"secondary":646},{"secondary":647},{"secondary":648},{"secondary":673},{"secondary":679},{"secondary":684},{"secondary":690},{"secondary":692},{"secondary":693},{"secondary":694},{"secondary":695},{"secondary":696},{"secondary":697},{"secondary":698},{"secondary":699},{"secondary":701},{"secondary":706},{"secondary":707},{"secondary":708},{"secondary":713},{"secondary":714},{"secondary":717},{"secondary":719},{"secondary":720},{"secondary":721},{"secondary":722},{"secondary":723},{"secondary":724},{"primary":103,"secondary":801},{"primary":103,"secondary":802},{"primary":103,"secondary":803},{"primary":323,"secondary":531},{"primary":338,"secondary":531},{"primary":339,"secondary":184},{"primary":568,"secondary":535},{"primary":674,"secondary":685}]}}

Checking the backend call directly shows these two clinics are not being returned:
https://veteran.apps-staging.va.gov/vaos/v1/locations/983/clinics?patientIcn=1012853802V084487&clinicalService=primaryCare&enableStopCodeFilter=true

This is the front end call, which includes the two excluded clinics (455 CHY PC Cassidy & 457 Green Team Clinic2):
https://staging.va.gov/my-health/appointments/schedule/clinic

 "data": [
      {
          "id": "308",
          "type": "clinics",
          "attributes": {
              "vistaSite": 983,
              "id": "308",
              "serviceName": "Green Team Clinic1",
              "physicalLocation": "CHEYENNE",
              "phoneNumber": null,
              "stationId": "983",
              "stationName": "CHYSHR-Cheyenne VA Medical Center",
              "primaryStopCode": 323,
              "primaryStopCodeName": "PRIMARY CARE/MEDICINE",
              "secondaryStopCode": null,
              "secondaryStopCodeName": "*Missing*",
              "patientDirectScheduling": true,
              "patientDisplay": true,
              "char4": "TECH"
          }
      },
      {
          "id": "455",
          "type": "clinics",
          "attributes": {
              "vistaSite": 983,
              "id": "455",
              "serviceName": "CHY PC CASSIDY",
              "physicalLocation": null,
              "phoneNumber": null,
              "stationId": "983",
              "stationName": "CHYSHR-Cheyenne VA Medical Center",
              "primaryStopCode": 323,
              "primaryStopCodeName": "PRIMARY CARE/MEDICINE",
              "secondaryStopCode": 531,
              "secondaryStopCodeName": "PRI CARE FOR PTS WITH SMI",
              "patientDirectScheduling": true,
              "patientDisplay": true,
              "char4": null
          }
      },
      {
          "id": "457",
          "type": "clinics",
          "attributes": {
              "vistaSite": 983,
              "id": "457",
              "serviceName": "Green Team Clinic2",
              "physicalLocation": null,
              "phoneNumber": null,
              "stationId": "983",
              "stationName": "CHYSHR-Cheyenne VA Medical Center",
              "primaryStopCode": 323,
              "primaryStopCodeName": "PRIMARY CARE/MEDICINE",
              "secondaryStopCode": 117,
              "secondaryStopCodeName": "NURSING (2ND ONLY)",
              "patientDirectScheduling": true,
              "patientDisplay": true,
              "char4": null
          }
      },
      {
          "id": "848",
          "type": "clinics",
          "attributes": {
              "vistaSite": 983,
              "id": "848",
              "serviceName": "CHY PC VAR2",
              "physicalLocation": null,
              "phoneNumber": "801-555-0000",
              "stationId": "983",
              "stationName": "CHYSHR-Cheyenne VA Medical Center",
              "primaryStopCode": 350,
              "primaryStopCodeName": "PRIMARY CARE/MEDICINE",
              "secondaryStopCode": 534,
              "secondaryStopCodeName": "*Missing*",
              "patientDirectScheduling": true,
              "patientDisplay": true,
              "char4": null
          }
      }
  ]
}

When vets selects one of those clinics to direct schedule, VAOS gives an error on this call https://staging-api.va.gov/vaos/v2/appointments

Specs

  • Device: N/A
  • Browser: N/A

Steps to Reproduce

Test User: ruben.moreno@id.me

  1. Login and Ruben Moreno.
  2. Select Primary Care.
  3. Select "Show 6 more locations"
  4. Select 983, Cheyenne VA Medical Center.

Actual Result

Clinic IEN 455 CHY PC Cassidy and Clinic IEN 457 Green Team Clinic2 both have stop codes on the exclusion list above and are being returned for direct scheduling.

Desired Result

Clinics with stop code on the above list are not available for direct Scheduling

Definition of Done

  • Desired result is achieved and/or document decisions made
  • Relevant documentation is updated

@JRRoof JRRoof added appointments VA Online Scheduling tool product tag bug Something isn't working labels Dec 18, 2024
@JRRoof JRRoof self-assigned this Dec 18, 2024
@JRRoof JRRoof added backend needs-grooming Use this to designate any issues that need grooming from the team labels Dec 18, 2024
@simiadebowale
Copy link
Contributor

Appointments FE is passing the enableStopCodeFilter=true flag in vets-api but VPG is not consuming flag and passing it to vaos-service when making a call to /locations/#{location_id}/clinics. Started a thread with VPG team to resolve issue.

Note: Issue only affects staging since vpg is currently only live in staging

@simiadebowale simiadebowale removed the needs-grooming Use this to designate any issues that need grooming from the team label Dec 18, 2024
@simiadebowale simiadebowale self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appointments VA Online Scheduling tool product tag backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants