-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component and spacing tokens to variables.css
#3629
Comments
Foundation tokensWe need to add some missing design tokens from our Foundational set to variables that we export to other systems:
Spacing units is the priority for this issue. Engineers should be able to add this to our list of variables quickly. Component tokensThen we should move onto components. Form Engine team has prioritized these components for us:
We had started on defining component-level tokens for va-button. We need to complete that token list and repeat that for the other components. Designers should start on this as soon as possible (and I can assist as needed). |
Adding the tokens will be done in #3706. Once that is done, engineers can work on this issue. |
Please add your estimate of 1, 2, 3, 5, 8 or 13 |
Spacing tokens are available as version 0.18.0 of the CSS library. We will work on the component tokens but that will be in a future sprint. |
This is less a "bug" and more of a feature request, but there is some expected behavior that I did not see.
Bug Report
What happened
In trying to use the tokens in
variables.css
(unpkg link), I did not find tokens for web components or web spacing.https://dsva.slack.com/archives/CBU0KDSB1/p1734455105370889?thread_ts=1733170194.602409&cid=CBU0KDSB1
What I expected to happen
I expected to see all the tokens I would need in order to match VADS components and overall layout.
Reproducing
N/A
Steps to reproduce:
N/A
1.
2.
3.
4.
Urgency
How urgent is this request? Please select the appropriate option below and/or provide details
We can implement these "by hand", but it'd be nice to stay coupled with the design system so this is less fragile later.
Details
The text was updated successfully, but these errors were encountered: