Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frontend logic for PMR Pending items #96607

Open
janechodance opened this issue Nov 6, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-website#33049
Open

Remove frontend logic for PMR Pending items #96607

janechodance opened this issue Nov 6, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-website#33049
Assignees
@janechodance
Labels
benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2

Comments

@janechodance
Copy link

janechodance commented Nov 6, 2024 •
edited by dysbo
Loading

There are two backend changes that require simple, corresponding frontend changes.

For PMR Pending items, the related frontend change is here. Looking at this now, I will have to make another small change to the backend to change displayName there, rather than the frontend. However, the crux of the thing is this frontend code will be unnecessary after the backend changes are done. The frontend can go back to just displaying the information it's given, rather than using these two overrides.

Acceptance Criteria

  1. Special FE handling for Tracked Items received as PMR Pending is removed (see link above)
  2. Text displayed for PMR Pending / Private Medical Record items is still rendering correctly (no visible change)

Screenshots

Image
@dysbo dysbo added benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2 needs-refinement Identifies tickets that need to be refined labels Nov 6, 2024
@janechodance janechodance self-assigned this Nov 12, 2024
@janechodance janechodance changed the title Remove frontend logic Remove frontend logic for PMR Pending items Nov 12, 2024
@dysbo dysbo removed the needs-refinement Identifies tickets that need to be refined label Nov 12, 2024
@janechodance janechodance linked a pull request Nov 15, 2024 that will close this issue
Draft
14 tasks
@janechodance janechodance linked a pull request Nov 15, 2024 that will close this issue
remove override PMR logic department-of-veterans-affairs/vets-website#33049
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janechodance janechodance

Labels
benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove override PMR logic department-of-veterans-affairs/vets-website
2 participants
@dysbo @janechodance