Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix version for vulnerable dependencies #2389

Closed
milind009 opened this issue Jul 30, 2020 · 1 comment
Closed

Security fix version for vulnerable dependencies #2389

milind009 opened this issue Jul 30, 2020 · 1 comment
Labels
core 🍏 Relates to the dependabot-core library itself F: security-updates 🔐 Issues specific to security updates L: javascript:npm npm packages via npm L: javascript:yarn npm packages via yarn

Comments

@milind009
Copy link
Contributor

milind009 commented Jul 30, 2020

Recently, I was going through how dependabot handles dependency updates in case of vulnerable dependencies for npm and yarn based repos. Few questions I had around that are -

  • For direct dependencies, it returns the lowest security fix version but it does not check whether the version is resolvable or not (i.e checking for peer dependencies requirements and other checks as is done while getting the latest resolvable version)

  • Currently for npm and yarn, dependabot handles security update only for requirements_to_unlock = :own. Is it not applicable for :none and :all or is there some other reason behind not implementing it for the other two values?

@feelepxyz Is there any implemetation detail that makes these scenarios invalid? Can you take a look once?

@lseppala lseppala added F: security-updates 🔐 Issues specific to security updates L: javascript:npm npm packages via npm L: javascript:yarn npm packages via yarn core 🍏 Relates to the dependabot-core library itself labels Dec 7, 2021
@jeffwidman
Copy link
Member

This code has changed a lot in the 2+ years since this issue was filed, and the behavior described above is likely no longer true... especially because we invested some effort into improving how we handle security updates for npm / yarn over the past year.

I'm going to close, but if you're still looking for answer, please take a look at the current source to see which questions are still relevant and then comment and we can re-open or perhaps easier to simply file a new ticket. To be clear, we are happy to answer questions, I just don't want to spend time digging in the source given that it's likely you're no longer interested in the answers to two-year-old questions.

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🍏 Relates to the dependabot-core library itself F: security-updates 🔐 Issues specific to security updates L: javascript:npm npm packages via npm L: javascript:yarn npm packages via yarn
Projects
None yet
Development

No branches or pull requests

3 participants