Bundler: Fix permission error when vendoring gems #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a permissions error when vendoring gems, when `GEM_HOME` was unset it defaulted to `/var/lib` which isn't writeable. Attempting to fix the discrepancy between ci and updater here: #3279
jurre
approved these changes
Mar 16, 2021
Yes attempted to do it here #3279 but looks like it's breaking a whole tonne of stuff in the process so keen to get this out to fix the issue in prod and then try and get that PR working. I can reproduce it in the dev container and the vendor specs also fail in the dev container but pass in the ci container because they run as root. |
|
@jurre reproduced the failure here https://github.com/dependabot/dependabot-core/runs/2122196759 🎉 |
|
Tested successfully on staging https://github.com/dsp-testing/feelepxyz-testing-git-bundler/pull/12/files |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a permissions error when vendoring gems, when
GEM_HOMEwasunset it defaulted to
/var/libwhich isn't writeable.Attempting to fix the discrepancy between ci and updater here:
#3279