Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With each report, include whether or not the affected dependency is a dev dependency #5247

Closed
ehuelsmann opened this issue Jun 8, 2022 · 3 comments
Labels
T: feature-request Requests for new features

Comments

@ehuelsmann
Copy link

Almost all issues reported on our repository (ledgersmb/LedgerSMB) are filed against dev dependencies. The vulnerabilities are being reported with an attack vector Network, but in our case the attack vector becomes Local (because the development setups aren't publicly accessible) or they require social engineering skills where an attacker convinces a developer to merge code which triggers this vulnerability. Both of these situations warrent much lower ratings than the standard CSSv3 ratings.

Please:

  1. Indicate that the affected components are dev dependencies to allow prioritization as such
  2. Allow us to dismiss vulnerabilities, indicating that the risk for our repository is much lower than the standard CSSv3 rating

Thanks in advance!

@ehuelsmann ehuelsmann added the T: feature-request Requests for new features label Jun 8, 2022
@mattt
Copy link
Contributor

mattt commented Jun 14, 2022

Thanks so much for sharing your idea, @ehuelsmann. I agree that distinguishing dev dependencies would be useful for a lot of folks, for exactly that reason — the threat model for things running locally seems quite different from things running in production. That high-severity ReDoS vulnerability, for example, may not be too concerning if it only affects a build tool.

We're definitely interested in solving this alert fatigue / "boy who cried wolf" situation, and think this could be a good first step.

See also #4146

@jeffwidman
Copy link
Member

Yeah, I think this is resolved by https://github.blog/changelog/2022-06-23-dependabot-alerts-filter-alerts-by-the-scope-of-the-dependency-runtime-and-development/.

Also, to clarify, this issue is about the alerts, whereas this repo is for the code that creates version-bump PR's (which may be triggered to rectify alerts)... so going forward, issues about security alerts themselves rather than PR's from security alerts shouldn't be filed against this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

4 participants