Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry +1.2 is not updating group.dev.dependencies when using new group syntax vs dev-dependencies #6659

Closed
1 task done
magame95 opened this issue Feb 13, 2023 · 6 comments · Fixed by #6673
Closed
1 task done
Labels
L: python:poetry Python packages via poetry T: bug 🐞 Something isn't working

Comments

@magame95
Copy link

magame95 commented Feb 13, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

pip (poetry)

Package manager version

Poetry 1.2

Language version

Python 3.9

Manifest location and content before the Dependabot update

Location: /pyproject.toml
Content:

[tool.poetry]
name = "dependabot-poetry13"
version = "0.1.0"
description = ""
authors = ["magame95 <galavix.mendez@gmail.com>"]
readme = "README.md"
packages = [{include = "dependabot_poetry13"}]

[tool.poetry.dependencies]
python = "^3.9"
django = "^4.1.6"


[tool.poetry.group.dev.dependencies]
flake8 = "^5.0.4"
pre-commit = "^2.21.0"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

dependabot.yml content

version: 2
updates:
  - package-ecosystem: "pip"
    directory: "/"
    schedule:
      interval: "daily"

Updated dependency

flake8 5.0.4 to 6.0.0
pre-commit 2.21.0 to 3.0.4

What you expected to see, versus what you actually saw

Expected:
Dependabot creates 2 PRs
Bump flake8 from 5.0.4 to 6.0.0
Bump pre-commit from 2.21.0 to 3.0.4

Resulted:
Dependabot determined that updated was not possible (from logs).

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

I created 2 test repos to demonstrate de difference between dependabot usage between poetry new group and old dev-dependencies syntax.
https://github.com/magame95/dependabot-poetry1.3
https://github.com/magame95/dependabot-poetry12 (Note how dependabot opened 2 PRs for the dependencies in question)

Also, if you see at the Insights for dev-dependencies, its displaying development dependencies under Dependencies defined in pyproject.toml in constrast to the group syntax repo Insights

new group.dev.dependencies syntax
image
old dev-dependencies syntax
image

Smallest manifest that reproduces the issue

No response

@magame95 magame95 added the T: bug 🐞 Something isn't working label Feb 13, 2023
@magame95 magame95 changed the title Poetry +1.2 is not updating group.dev.depedencies when using new group syntax vs dev-dependencies Poetry +1.2 is not updating group.dev.dependencies when using new group syntax vs dev-dependencies Feb 13, 2023
@deivid-rodriguez deivid-rodriguez added the L: python:poetry Python packages via poetry label Feb 15, 2023
@deivid-rodriguez
Copy link
Contributor

Hi @magame95!

The issue with missing PRs is indeed a problem with this library. I can reproduce it and I'm working on a fix.

The issue with the insights tab is also a problem, but it's not specific to the Dependabot update logic, but an issue with the Dependency Graph built by the Github.com site itself. I will make sure to pass the information along to the proper team, but you may want to open an issue about this at https://github.com/community/community/discussions/categories/code-security for better visibility.

@deivid-rodriguez
Copy link
Contributor

#6673 should fix the issue with missing PRs!

@magame95
Copy link
Author

@deivid-rodriguez Thank you for your swift response and work 😃! I just open a discussion relating the dependency graph issue as you suggested.

@magame95
Copy link
Author

magame95 commented Mar 1, 2023

Hi! Notice #6673 got merge 👍 , I'm not familiar with how dependabot gets deployed, may I assume that the fix is already live?

@jeffwidman
Copy link
Member

I just finished deploying it. Please kick the tires and you're still seeing issues please let us know.

@magame95
Copy link
Author

magame95 commented Mar 1, 2023

Works like a charm now ❤️. I can confirm dependabot opens expected PRs for dependencies under poetry groups! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: python:poetry Python packages via poetry T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants