Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver 2.0 versions not handled correctly for nuget pre-release dependencies #1972

Closed
andreasohlund opened this issue Jun 3, 2020 · 9 comments · Fixed by #4833
Closed

Semver 2.0 versions not handled correctly for nuget pre-release dependencies #1972

andreasohlund opened this issue Jun 3, 2020 · 9 comments · Fixed by #4833
Assignees
Labels
good first issue L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working

Comments

@andreasohlund
Copy link

When the bot open PRs for pre-releases the version parsing doesn't work properly for semver 2.0 versions.

Particular/NServiceBus.Gateway.Sql#34 shows this where 3.2.0-alpha.66 is a higher version than 3.2.0-alpha0014 so no PR should have been created.

@infin8x infin8x transferred this issue from dependabot/feedback Jun 29, 2020
@gitfool
Copy link

gitfool commented Sep 3, 2020

I just hit a variant of this:

Bump coverlet.collector from 1.3.1-preview.24.g6479f627e4 to 1.3.1-preview.8.ge848786b0d

@gitfool
Copy link

gitfool commented Oct 4, 2020

A quick look at the relevant Dependabot source confirms that the prerelease part of the version is still compared lexically, without considering dot separated identifiers consisting of only digits that should be compared numerically:

prerelease_string.<=>(other_prerelease_string)

@andreasohlund
Copy link
Author

Any updates on this? (we had this happen again recently - Particular/NServiceBus.Callbacks#198)

@adamralph
Copy link

@adamralph
Copy link

and again - Particular/NServiceBus.AmazonSQS#807, Particular/NServiceBus.AmazonSQS#808, Particular/NServiceBus.AmazonSQS#809

Is there any likelihood of this being prioritised? This behaviour is killing the entire purpose of dependabot.

@adamralph
Copy link

This keeps biting again and again and again.

Is there any intention of fixing it?

@adamralph
Copy link

Have the maintainers even acknowledged that the problem exists? I noticed that it has not been marked as a bug, like other issues have — https://github.com/dependabot/dependabot-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22T%3A+bug+%F0%9F%90%9E%22

This was referenced Sep 2, 2021
This was referenced Sep 8, 2021
@mctofu mctofu added L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working labels Dec 7, 2021
@josesimoes
Copy link

This keeps being a tad annoying... 😉

@jakecoffman
Copy link
Member

The fix for this is in v0.178.1 which is deployed internally now, so it shouldn't happen anymore! Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants