Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata fields alert-state, ghsa-id & cvss are never populated when the manifest file is at the root #185

Closed
SalimBensiali opened this issue Mar 24, 2022 · 9 comments · Fixed by #186
Labels
bug Something isn't working

Comments

@SalimBensiali
Copy link
Contributor

If you look at https://github.com/SalimBensiali/le-blanc-jewellery/runs/5561937034?check_suite_focus=true, you would expect to see the relevant vulnerability alert metadata, but I am always getting the default data instead, ie:

outputs.alert-state: ''
outputs.ghsa-id: ''
outputs.cvss: 0

image

@lindan-betterment
Copy link

I am experiencing the same issue.

@mwaddell
Copy link
Contributor

@SalimBensiali your repository is not configured to use Dependabot security updates and alerts:

image

I updated the README (see #187) to make it explicit that this feature relies upon those being enabled. My apologies for the confusion.

@SalimBensiali
Copy link
Contributor Author

SalimBensiali commented Mar 27, 2022

@mwaddell my repo does have dependabot security updates and alerts enabled. Look at any previously closed dependabot alerts via the auto merge workflow https://github.com/SalimBensiali/le-blanc-jewellery/pulls?q=is%3Apr+is%3Aclosed

The issue I am reporting relates the v1.3.0 new feature alert-lookup

@SalimBensiali
Copy link
Contributor Author

I think you simply don't have the permissions to view them
image

@SalimBensiali
Copy link
Contributor Author

SalimBensiali commented Mar 27, 2022

@mwaddell I managed to run the dry-run command which successfully returned the missing metadata for me.
image

Could it be because your LOCAL_GITHUB_ACCESS_TOKEN does not give you permission to access the data? Which would be consistent with not seeing that dependabot security alerts and updates are enabled on https://github.com/SalimBensiali/le-blanc-jewellery/security.

@SalimBensiali
Copy link
Contributor Author

SalimBensiali commented Mar 27, 2022

The docs you are linking to in #187 (https://docs.github.com/en/code-security/dependabot/dependabot-alerts/about-dependabot-alerts#access-to--dependabot-alerts) do explain why you could not see any dependabot alerts on my repo.

By default, we notify people with admin permissions in the affected repositories about new Dependabot alerts. GitHub never publicly discloses identified vulnerabilities for any repository. You can also make Dependabot alerts visible to additional people or teams working repositories that you own or have admin permissions for. For more information, see "Managing security and analysis settings for your repository."

This is further confirmed here.

@SalimBensiali
Copy link
Contributor Author

@mwaddell you could run the dry-run command off main and my branch and target a test repo you own to verify the bug and the fix. All you need is a repo with a manifest file in the root directory and any dependabot PR.

@mwaddell
Copy link
Contributor

Thank you for the additional clarification - I understand now. Thank you for the PR and for updating all the unit tests, I've reviewed and approved the changes for @brrygrdn to merge.

@SalimBensiali
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants