Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting Webpack configurations that export a Promise #82

Open
pyrrho opened this issue Jul 31, 2019 · 0 comments
Open

Consider supporting Webpack configurations that export a Promise #82

pyrrho opened this issue Jul 31, 2019 · 0 comments

Comments

@pyrrho
Copy link

pyrrho commented Jul 31, 2019

Webpack -- I believe since version 2 -- has been able to export a promise as it's configuration object. At the time of writing, filing-cabinet does check if the config object is a function, but this if branch will be spuriously matched in the case of an exported Promise, and will (eventually) result in result in an UnhandledPromiseRejectionWarning being thrown.

I'm not sure if there's an easy fix for this missing feature, though, so I would understand if handling promises in this manner isn't in scope for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant