Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in tsConfig options resolving #85

Closed
vansosnin opened this issue Nov 15, 2019 · 3 comments
Closed

Issue in tsConfig options resolving #85

vansosnin opened this issue Nov 15, 2019 · 3 comments

Comments

@vansosnin
Copy link
Contributor

Hello!

Noticed that method that is being used to resolve ts config compiler options not working properly if passed config has extends field.

const {options} = ts.convertCompilerOptionsFromJson(tsConfig.compilerOptions);

Maybe try using parseJsonConfigFileContent from TS Compiler API? It resolves CompilerOptions well, though a bit more complicated in use: you need to create an instance of ParseConfigHost. It can be done like here.

@vansosnin
Copy link
Contributor Author

Wrote red test. Using parseJsonConfigFileContent did not work. Have no idea now about how to resolve extending TS config. Any thoughts?

@vansosnin
Copy link
Contributor Author

Okay, now it seems working. Can someone check the PR? @mrjoelkemp maybe?

@mrjoelkemp
Copy link
Collaborator

Merged and released. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants