Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Rust Toolchain version? #48

Closed
Feliix42 opened this issue Sep 29, 2020 · 5 comments
Closed

Fixed Rust Toolchain version? #48

Feliix42 opened this issue Sep 29, 2020 · 5 comments
Assignees
Labels
infrastructure Infrastructure-related issues

Comments

@Feliix42
Copy link
Member

As we just discussed in #44, the project is currently running on a Nightly toolchain. There's nothing wrong with that, but to avoid having a broken build out of nowhere we should either lock on a specific nightly version that is guaranteed to work or look into whether we can somehow move to stable easily.

I'm going to take a look and see how extensive the use of nightly-only features is.

@Feliix42 Feliix42 added the infrastructure Infrastructure-related issues label Sep 29, 2020
@Feliix42 Feliix42 self-assigned this Sep 29, 2020
@robjtede
Copy link
Member

AFAICT it's just maud (HTML templating) that's nightly only.

I'm fine with nightly fixed for now but would very much like to move to stable.

@jamiebrynes7
Copy link
Member

If its the case that maud is the only nightly dependency, we may be able to move to stable soon if this milestone is still up-to-date. https://github.com/lambda-fairy/maud/milestone/1

@Feliix42
Copy link
Member Author

lambda-fairy/maud#219 moved the project to stable so we just have to wait for the next release. Should we still fix on a specific nightly version until then or are we just going to hope that there are no breaking changes to proc_macros?

@paolobarbolini
Copy link
Member

If they don't plan to make a new release soon we could also temporarily import it from git

@Enet4 Enet4 mentioned this issue Oct 1, 2020
@Enet4
Copy link
Contributor

Enet4 commented Oct 1, 2020

The toolchain version was fixed to nightly-2020-09-27 with #53. I filed a new issue to keep track of the path towards using a stable toolchain.

@Enet4 Enet4 closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure-related issues
Projects
None yet
Development

No branches or pull requests

5 participants