Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The attribute aria-expanded is not supported by the role menuitem. #76

Closed
jlurena opened this issue Aug 21, 2019 · 5 comments
Closed

The attribute aria-expanded is not supported by the role menuitem. #76

jlurena opened this issue Aug 21, 2019 · 5 comments

Comments

@jlurena
Copy link

jlurena commented Aug 21, 2019

Please see the same issue I posted here https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/630

A menu item, acting as a submenu given a role of menuitem should have an aria-expanded attribute. I am being thrown an error when I do this.

Something like this raises an error:

<ul role="menubar">
  <li>
    <a role="menuitem" aria-expanded="false" href="someurl.com">Some URL</a>
      <ul role="menu">
        <li><a href="https://google.com">Google.com</a></li>
        <li><a href="https://github.com">Github.com</a></li>
      </ul>
  </li>
</ul>

The attribute aria-expanded is not supported by the role menuitem.

According to w3c/aria#454 this is valid aria spec.

This is also shown on an example on W2
https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.html

@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 8, 2019

@jlurena thanks for reporting this. I will investigate and get back to you.

@jlurena
Copy link
Author

jlurena commented Sep 9, 2019

Specific aria-spec: https://www.w3.org/TR/wai-aria-practices-1.1/#menu

@jlurena
Copy link
Author

jlurena commented Jun 24, 2020

Was this fixed? @JKODU

@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 16, 2020

@jlurena

Thanks for this issue. It looks like js-ally-plugin does not report this as an issue now.

The latest version of axe-core v4.0.2 does not throw an issue for the above code snippet either.

I would recommend moving to the latest version of axe-core-*-gems, which uses the latest of axe-core. We have re-engineered the way the gems/ packages can be consumed.

@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 16, 2020

@jlurena feel free to re-open the issue, if you need further input.

@jeeyyy jeeyyy closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants