Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add timeout waiting for page to be ready #250

Merged
merged 1 commit into from
May 18, 2021

Conversation

Elte156
Copy link
Contributor

@Elte156 Elte156 commented May 11, 2021

Partly addresses #230

I discovered my CLI issue was because of the Content Security Policy (CSP) headers that I set in my web app.
When I set Content-Security-Policy to script-src 'unsafe-inline';, AXE is then able to process the page.

This timeout is to force AXE to fail after 10 seconds of waiting; instead of indefinitely waiting for .deque-axe-is-ready (which will never be injected because of strict CSP headers in place).

Sample output with timeout in place

Running axe-core 4.2.0 in chrome-headless

Testing http://example.com ... please wait, this may take a minute.
 
An error occurred while testing this page.
Please report the problem to: https://github.com/dequelabs/axe-cli/issues/

@michael-siek michael-siek requested a review from a team May 18, 2021 13:17
@michael-siek michael-siek changed the title fix(cli): add axe readiness timeout fix(cli): add timeout waiting for page to be ready May 18, 2021
@michael-siek
Copy link
Member

Thank you very much for your contribution @Elte156!

@michael-siek
Copy link
Member

  • reviewed for security

@michael-siek michael-siek merged commit cbb795f into dequelabs:develop May 18, 2021
@Elte156 Elte156 deleted the fix/timeout branch May 18, 2021 19:26
@Elte156
Copy link
Contributor Author

Elte156 commented May 18, 2021

No problem! @michael-siek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants