New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): return `this` rather than the class #360

Merged

WilcoFiers merged 1 commit into develop from return-this

Sep 9, 2021

Contributor

WilcoFiers commented Sep 9, 2021

These need to return this, so that the classes can properly be extended. If we didn't return this, the following would be a problem:

class DevToolsWebdriverIO extends AxeBuilder {
  foo() {}
}
// foo does not exist on type AxeBuilder
new DevToolsWebdriverIO().include('foo').foo();


          fix(types): return this rather than the class

3d90d48

WilcoFiers requested a review from michael-siek

September 9, 2021 12:21

Zidious approved these changes

View reviewed changes

WilcoFiers merged commit 7999891 into develop

WilcoFiers deleted the return-this branch

September 9, 2021 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet