feat: add disableFrame method #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
reviewed
Jun 30, 2020
| @@ -5,6 +5,7 @@ | |||
| </head> | |||
| <body> | |||
| <h1>Foo</h1> | |||
| <input type="text" name="firstname" id="firstname"> | |||
There was a problem hiding this comment.
What is the reason for doing this? It doesn't look like it's used in the test you created.
There was a problem hiding this comment.
Its just to add a violation.
| private iframeSelector(): string { | ||
| let selector = 'iframe'; | ||
| for (const disabledFrameSelector of this.disabledFrameSelectors) { | ||
| selector += `:not(${disabledFrameSelector})`; |
There was a problem hiding this comment.
This will fail if the selector passed in includes a comma-separated list: disableFrame('#topLevel, #otherLevel') as iframe:not(#topLevel, #otherLevel) is not a valid selector. Is that a problem?
There was a problem hiding this comment.
This is what we do in attest-webdriverio which also has this method.
straker
approved these changes
Jul 1, 2020
This was referenced Oct 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: dequelabs/axe-devtools-npm#636
Reviewer checks
Required fields, to be filled out by PR reviewer(s)