-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(playwright): allow include/exclude chaining when given a string by the user #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
changed the title
fix(playwright): allow chaining on exclude and include
[WIP]fix(playwright): allow chaining on exclude and include
Oct 25, 2021
Zidious
changed the title
[WIP]fix(playwright): allow chaining on exclude and include
fix(playwright): allow chaining on exclude and include
Oct 27, 2021
By the title of this PR, I expected the change to be |
Zidious
changed the title
fix(playwright): allow chaining on exclude and include
fix(playwright): allow include/exclude chaining when given as string by the user
Oct 27, 2021
Zidious
changed the title
fix(playwright): allow include/exclude chaining when given as string by the user
fix(playwright): allow include/exclude chaining when given a string by the user
Oct 27, 2021
stephenmathieson
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
May want @michael-siek to OK this before it lands though. I'll leave the security review to him.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow chaining of include/exclude when passed a string by the user
example:
closes issue: #389