Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playwright): allow include/exclude chaining when given a string by the user #391

Merged
merged 12 commits into from
Oct 29, 2021

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Oct 25, 2021

allow chaining of include/exclude when passed a string by the user

example:

 const results = await new AxeBuilder({ page })
        .exclude('.exclude')
        .exclude('.exclude2')
        .analyze();

closes issue: #389

@Zidious Zidious changed the title fix(playwright): allow chaining on exclude and include [WIP]fix(playwright): allow chaining on exclude and include Oct 25, 2021
@Zidious Zidious changed the title [WIP]fix(playwright): allow chaining on exclude and include fix(playwright): allow chaining on exclude and include Oct 27, 2021
@Zidious Zidious marked this pull request as ready for review October 27, 2021 14:13
@Zidious Zidious requested a review from a team October 27, 2021 14:13
@stephenmathieson
Copy link
Member

By the title of this PR, I expected the change to be return this, not to allow multiple exclude/include selectors to be added 🤷

@Zidious Zidious changed the title fix(playwright): allow chaining on exclude and include fix(playwright): allow include/exclude chaining when given as string by the user Oct 27, 2021
@Zidious Zidious changed the title fix(playwright): allow include/exclude chaining when given as string by the user fix(playwright): allow include/exclude chaining when given a string by the user Oct 27, 2021
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

May want @michael-siek to OK this before it lands though. I'll leave the security review to him.

@Zidious Zidious merged commit 4b8ab26 into develop Oct 29, 2021
@Zidious Zidious deleted the fix/include-exclude-chaining branch October 29, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants