fix(puppeteer): get results from within iframes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdnoC
force-pushed
the
fix-puppeteer-iframes
branch
from
1db4050
to
b44186b
Compare
AdnoC
changed the title
stephenmathieson
previously requested changes
Jul 7, 2020
| // We don't set `brand` since `axe-webdriverjs` doesn't. | ||
| // TODO: Once axe-core 3.1.3 is released remove the cast (as that release fixes the types) | ||
| window.axe.configure(brandingConfig as Axe.Spec); | ||
| // This prevents axe from running in iframes. |
packages/puppeteer/src/browser.ts
Outdated
| // TODO: Once axe-core 3.1.3 is released remove the cast (as that release fixes the types) | ||
| window.axe.configure(brandingConfig as Axe.Spec); | ||
| // This prevents axe from running in iframes. | ||
| // TODO: Uncomment when that is fixed in axe-core |
There was a problem hiding this comment.
Please link the axe-core issue here.
| @@ -26,7 +26,9 @@ describe('doc-dylang.html', function () { | |||
| await this.page.close(); | |||
| }); | |||
|
|
|||
| it('should find violations with customized helpUrl', async function () { | |||
| // Fails since we can't set branding due to a bug. | |||
| // TODO: Run once we fix setting branding | |||
There was a problem hiding this comment.
Please link the relevant axe-core issue here.
stephenmathieson
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/dequelabs/axe-devtools-npm/issues/650
Root cause is dequelabs/axe-core#2340
Reviewer checks
Required fields, to be filled out by PR reviewer(s)