fix(cli): add timeout to webdriver.js
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Jul 9, 2020
| @@ -2,8 +2,10 @@ const chromedriver = require('chromedriver'); | |||
| const { Builder, Capabilities } = require('selenium-webdriver'); | |||
| const chrome = require('selenium-webdriver/chrome'); | |||
|
|
|||
| function startDriver(config) { | |||
| async function startDriver(config) { | |||
There was a problem hiding this comment.
It seems to me this could be solved without a breaking change, by having ADT itself call setTimeouts. I don't think we should introduce a breaking change like this if we can avoid it. Seems unnecessary.
There was a problem hiding this comment.
I think this is a necessary change since axe core cli have a default value for settimeout and if we move it into this file it wouldn't get called since we pass in our driver instance from adt/cli -> axe-core cli
WilcoFiers
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/dequelabs/axe-devtools-npm/issues/697
Reviewer checks
Required fields, to be filled out by PR reviewer(s)