fix(webdriverjs): Enable library to work in pkged programs
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
changed the title
executeAsyncScript instead of functionpkged programs
stephenmathieson
previously requested changes
Jul 10, 2020
| @@ -96,25 +96,28 @@ class AxeInjector { | |||
| return new Promise((resolve, reject) => { | |||
| /* eslint-disable no-undef */ | |||
| this.driver | |||
| .executeAsyncScript(function (callback) { | |||
| const iframes = Array.from( | |||
| .executeAsyncScript( | |||
There was a problem hiding this comment.
Please add a comment explaining why this is necessary and link to vercel/pkg#676
| context, | ||
| options, | ||
| config | ||
| ` |
There was a problem hiding this comment.
Same as above. Add a comment please.
| assert.equal(config, catsConfig); | ||
| executeAsyncScript: function (callback) { | ||
| // Since we are stringifying executeAsyncScript we need to see if config gets passed into executeAsyncScript | ||
| const [cats] = callback.match(/\s*("options":\s*\["cats"])/g); |
There was a problem hiding this comment.
I guess you're not adding this. We have a strange obsession with cats in a lot of our older codebases.
There was a problem hiding this comment.
I can change it to bears? 🐻
stephenmathieson
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/dequelabs/axe-devtools-npm/issues/715
Reviewer checks
Required fields, to be filled out by PR reviewer(s)