fix: change playwright to devdep and use playwright-core types
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
requested changes
Sep 14, 2022
There was a problem hiding this comment.
One thing inline
nit - we may also want to use the types from playwright-core in axe-playwright.spec.ts too
| @@ -53,6 +52,8 @@ | |||
| "express": "^4.18.1", | |||
| "mocha": "^10.0.0", | |||
| "nyc": "^15.1.0", | |||
| "playwright": "^1.0.0", | |||
| "playwright-core": "^1.25.2", | |||
There was a problem hiding this comment.
playwright-core probably needs to be a dependency as we are utilising functions from Playwright rather than just exposing their types
There was a problem hiding this comment.
Technically we use the instance of playwright being passed in from the user so that the API only uses playwright-core types and the only time we use playwright is within the test.
Zidious
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #536, #536