Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to use axe-core@4.5.0 #589

Merged
merged 2 commits into from
Oct 26, 2022
Merged

feat: upgrade to use axe-core@4.5.0 #589

merged 2 commits into from
Oct 26, 2022

Conversation

michael-siek
Copy link
Member

No description provided.

@michael-siek michael-siek requested a review from a team October 25, 2022 19:20
stephenmathieson
stephenmathieson approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Why haven't we created a robot (GH Action) to do this automagically yet? I see all of the PRs you opened which could have easily been scripted.

@michael-siek
Copy link
Member Author

@stephenmathieson I agree will create a GH action to do this

@michael-siek michael-siek merged commit 4343d9d into develop Oct 26, 2022
@michael-siek michael-siek deleted the feat/axe-core@4.5 branch October 26, 2022 00:03
@michael-siek michael-siek mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-siek @stephenmathieson