feat: add @axe-core/puppeteer
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![axe-linter[bot]](https://avatars.githubusercontent.com/in/60252?s=60&v=4){kind=small}
michael-siek
commented
May 15, 2020
michael-siek
commented
May 15, 2020
michael-siek
commented
May 15, 2020
| @@ -0,0 +1,11 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
added lang=en to all the test so axe-linter doesnt error
There was a problem hiding this comment.
I believe these files are meant to have a11y errors. Should we just disable them in .github/axe-linter.yml instead?
There was a problem hiding this comment.
Are they suppose to have html lang a11y errors? if so should I do something like
exclude:
- packages/puppeteer/test/*There was a problem hiding this comment.
Since the tests are passing now, I don't think it's a big deal.
stephenmathieson
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed tslint and prettier in puppeteer and also removed them from npm since we run it at the root level