fix: proper imports in esm context #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
previously requested changes
May 2, 2023
packages/puppeteer/src/legacy.ts
Outdated
Comment on lines
57
to
68
| let axeCorePath = ''; | ||
| if (typeof require === 'function' && typeof require.resolve === 'function') { | ||
| axeCorePath = require.resolve('axe-core'); | ||
| } else { | ||
| const { createRequire } = (await import('node:module')) as any; | ||
| const filename = pathToFileURL(getFilename()).toString(); | ||
|
|
||
| const require = createRequire(filename); | ||
| axeCorePath = require.resolve('axe-core'); | ||
| } | ||
|
|
||
| const source = fs.readFileSync(axeCorePath, 'utf8'); |
There was a problem hiding this comment.
We should comment on why this was necessary to add vs just using __filename
Zidious
previously requested changes
May 2, 2023
Zidious
previously approved these changes
May 2, 2023
Zidious
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #717