Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creating a canary on push into release in deploy.yml #867

Closed
dequejenn opened this issue Oct 11, 2023 · 0 comments · Fixed by #875
Closed

Add creating a canary on push into release in deploy.yml #867

dequejenn opened this issue Oct 11, 2023 · 0 comments · Fixed by #875
Assignees
Labels
in sprint Ticket is in current sprint QA: none This ticket does not require QA signoff TYPE: task Ticket is for non-dev work

Comments

@dequejenn
Copy link
Contributor

dequejenn commented Oct 11, 2023

Currently we only create a canary build on commit into develop. However, there is a chance that the commits in develop were never pushed into the release branch for QA. To mitigate this use case, we need to also build a canary when a push to the release branch happens, so QA is always testing the correct codeset that will be deployed.

In deploy.yaml,

on:
  push:
    branches:
      - develop
      - master

needs to be

on:
  push:
    branches:
      - develop
      - release
      - master

AND

canary:
    runs-on: ubuntu-latest
    if: github.ref_name == 'develop' && github.repository_owner == 'dequelabs'

needs to be

canary:
    runs-on: ubuntu-latest
    if: (github.ref_name == 'develop' || github.ref_name == 'release') && github.repository_owner == 'dequelabs'
@dequejenn dequejenn added TYPE: task Ticket is for non-dev work QA: none This ticket does not require QA signoff labels Oct 11, 2023
@dequejenn dequejenn added the in sprint Ticket is in current sprint label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in sprint Ticket is in current sprint QA: none This ticket does not require QA signoff TYPE: task Ticket is for non-dev work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants