Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update axe-core to 4.2.0 #240

Merged
merged 8 commits into from
May 4, 2021
Merged

feat: update axe-core to 4.2.0 #240

merged 8 commits into from
May 4, 2021

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented May 3, 2021 •
edited
Loading

See: #233

@michael-siek michael-siek requested a review from a team May 3, 2021 18:01
@michael-siek michael-siek changed the title chore: update version to 4.2.0 feat: update version to 4.2.0 May 3, 2021
@michael-siek michael-siek changed the title feat: update version to 4.2.0 feat: update axe-core to 4.2.0 May 3, 2021
stephenmathieson
stephenmathieson approved these changes May 4, 2021
View reviewed changes
packages/webdriverio/src/index.ts Outdated Show resolved Hide resolved
packages/webdriverjs/src/axe-injector.ts Outdated Show resolved Hide resolved
stephenmathieson
stephenmathieson approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think long-term, we should make the allowedOrigins thing configurable.

stephenmathieson
stephenmathieson requested changes May 4, 2021
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed } in a couple spots.

packages/puppeteer/src/browser.ts Show resolved Hide resolved
packages/webdriverio/src/index.ts Outdated Show resolved Hide resolved
packages/webdriverjs/src/axe-injector.ts Outdated Show resolved Hide resolved
@michael-siek michael-siek changed the title feat: update axe-core to 4.2.0 [wip]feat: update axe-core to 4.2.0 May 4, 2021
@michael-siek michael-siek changed the title [wip]feat: update axe-core to 4.2.0 feat: update axe-core to 4.2.0 May 4, 2021
@michael-siek michael-siek merged commit 4e8f7fe into develop May 4, 2021
@michael-siek michael-siek deleted the chore/axe-core4.2 branch May 4, 2021 18:00
@dbjorge dbjorge mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-siek @stephenmathieson @straker