Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playwright axe dotnet migration #26

Merged
merged 30 commits into from
Aug 24, 2022

Conversation

IsaacWalker
Copy link
Collaborator

This PR is part of an ongoing collaboration between myself, @TroyWalshProf, Microsoft, and Deque to migrate SeleniumAxeDotnet and PlaywrightAxeDotnet to be an official, Deque-supported Axe integration library.

This PR merges the main branch of PlaywrightAxeDotnet into this repos /packages/playwright. This work is licensed under the MIT License.

A large volume of the files is a result of using the Zero-Installs approach of Yarn V2. If desired it is acceptable for me to revert to the traditional approach as part of this PR.

IsaacWalker and others added 29 commits May 2, 2022 17:37
…pty-by-default

Making Result Tags Empty By Default
…f-result-and-node-result

updated nullability of result and node result
…y-and-added-tests

Fixed Report Directory override and added tests
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2022

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented Aug 22, 2022

@IsaacWalker Is the Playwright.Axe NodeDependencies and .yarn/cache suppose to be in the pr?

@IsaacWalker
Copy link
Collaborator Author

@IsaacWalker Is the Playwright.Axe NodeDependencies and .yarn/cache suppose to be in the pr?

Originally that was meant to reduce install time by having an online cache (Yarn V2 zero-installs). I've migrated to yarn v1 for now.

@michael-siek michael-siek changed the title Migrate playwright feat: playwright axe dotnet migration Aug 24, 2022
@michael-siek
Copy link
Member

Hey @IsaacWalker do you mind signing the CLA Contributor License Agreement

@michael-siek
Copy link
Member

  • reviewed for security

@michael-siek michael-siek merged commit f64ed93 into dequelabs:develop Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants