feat(playwright): remove html reporting support #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGibson2019
approved these changes
Aug 31, 2022
|
Security review seems broken. I approve this PR for security. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes HTML reporting support from
Deque.AxeCore.Playwright, with the intention that it will be moved to a separate package in a different repo based onDeque.AxeCore.Commonsthat consolidates the Selenium and Playwright reporting functionality.With this removal, almost none of the
NodeDependencieslogic remained necessary. I felt that the easiest option was to just rip it out entirely and replace it with a copy of theDeque.AxeCore.Seleniumsetup for embeddingaxe-corefor now. I expect that even this part will be replaced with @JGibson2019 's work to consolidate theaxe-coreembedding into the commons project as part of #8.Closes Issue: #17