Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source control metadata to packages #51

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Sep 2, 2022

Details

This PR adds source-linking metadata to each package using SourceLink, which allows IDEs to find the specific source commit/line during debugging that involves the packages. It does this by following the sourcelink docs to add a development-time (PrivateAssets="All") reference on Microsoft.SourceLink.GitHub.

The selenium package already had a (unnecessarily verbose) version of this in place; this PR updates all 3 packages to consistently use the recommended form of sourcelink reference.

You can verify the results of this by building, opening up the resulting .nupkg files, and finding a line like this embedded automatically into the included .nuspec file:

<repository type="git" url="https://github.com/dequelabs/axe-core-nuget" commit="b7b933324ab5201a361ef0a3b49a5fcae0494d19" />

Closes Issue: n/a

@AdnoC
Copy link
Contributor

AdnoC commented Sep 6, 2022

  • reviewed for security

@michael-siek michael-siek merged commit 1221d2e into dequelabs:develop Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants