Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playwright): swap out embedded axe-core for Commons version #54

Merged
merged 3 commits into from
Sep 8, 2022
Merged

feat(playwright): swap out embedded axe-core for Commons version #54

merged 3 commits into from
Sep 8, 2022

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Sep 6, 2022

Details

This PR removes the playwright project's embedded copy of axe-core in favor of reusing the embedded copy from the Commons project added in #46

Part of: #18

AdnoC
AdnoC approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@AdnoC AdnoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed for security

@michael-siek michael-siek merged commit 30186d9 into dequelabs:develop Sep 8, 2022
@dbjorge dbjorge mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdnoC AdnoC AdnoC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbjorge @AdnoC @michael-siek