Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame-tested for unloaded iframes #88

Open
straker opened this issue Jun 20, 2023 · 2 comments
Open

Add frame-tested for unloaded iframes #88

straker opened this issue Jun 20, 2023 · 2 comments
Assignees
Labels
bug Something isn't working in sprint Ticket is in current sprint web-apis

Comments

@straker
Copy link
Contributor

straker commented Jun 20, 2023

The change was made to our javascript APIs but needs to be ported to here.

@dequejenn dequejenn added bug Something isn't working and removed tech debt labels Jun 30, 2023
@dequejenn dequejenn added the in sprint Ticket is in current sprint label Jul 17, 2023
@dequejenn dequejenn removed the in sprint Ticket is in current sprint label Aug 31, 2023
@dequejenn dequejenn added the in sprint Ticket is in current sprint label Oct 10, 2023
@AdnoC AdnoC closed this as completed Oct 11, 2023
@padmavemulapati
Copy link

@gayathrit12 wil take care this

@gayathrit12
Copy link

For selenium packages, expecting frame-tested as incomplete result but viewing it in passes.

  1. For axe-core-nuget_selenium, able to view frame-tested in passes instead incomplete results

TestScript:

namespace AxeTest {
    public class SeleniumTests {
        public static void Main() {
           var options = new ChromeOptions();
            IWebDriver webDriver = new ChromeDriver(options);
            webDriver.Navigate().GoToUrl("http://localhost:8080/iframesfixture.html");
            AxeResult axeResult = new AxeBuilder(webDriver).Analyze();
            Console.WriteLine("Axe Results:");
            Console.WriteLine(axeResult);
           Console.WriteLine($"Number of Violations: {axeResult.Violations.Length}");
        }
    }
}

Screenshot:

image

Working scenario:

  1. axe-core-nuget_playwright is working fine with the lazy loaded iframes it is not hanging and giving frame-title violations.

Test script:

  [Test]
        public async Task RunAxe_NoOptions()
        {
            const string expectedViolationId = "aria-allowed-attr";

            await Page!.GotoAsync("http://localhost:8080/iframesfixture.html");

            AxeResult axeResults = await Page!.RunAxe();

Console.WriteLine($"Rules that failed:");
foreach(var violation in axeResults.Violations)
{
    Console.WriteLine($"Rule Id: {violation.Id} Impact: {violation.Impact} HelpUrl: {violation.HelpUrl}.");
  
}
Console.WriteLine($"Rules that did not fully run:");
foreach(var incomplete in axeResults.Incomplete)
{
    Console.WriteLine($"Rule Id: {incomplete.Id}");
}
}
}

Screenshot:

image

Note: As per @AdnoC, other than selenium packages, we can see a frame-title violationonly not aframe-tested` incomplete result, as this lazy loaded iframes fix is done for selenium.

Environment:

Label Value
Product axe-core-maven-html
Version 4.8.0
OS-Details _MAC- Intel Core i7 - 11.6.8 & Windows11 _
BrowserDetails Chrome Version 118.0.5993.70 (Official Build) (64-bit) & Firefox 118.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in sprint Ticket is in current sprint web-apis
Projects
None yet
Development

No branches or pull requests

7 participants