perf: Speed up getNodeFromTree (#1302)

* fix: speed up getNodeFromTree * remove return value for clear semantics * fix early return nit
dequelabs · Jan 9, 2019 · 5f834ed · 5f834ed
1 parent b9d1b57
commit 5f834ed
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/core/utils/flattened-tree.js b/lib/core/utils/flattened-tree.js
@@ -142,15 +142,13 @@ axe.utils.getNodeFromTree = function(vNode, node) {
 		return vNode;
 	}
 	vNode.children.forEach(candidate => {
-		var retVal;
-
+		if (found) {
+			return;
+		}
 		if (candidate.actualNode === node) {
 			found = candidate;
 		} else {
-			retVal = axe.utils.getNodeFromTree(candidate, node);
-			if (retVal) {
-				found = retVal;
-			}
+			found = axe.utils.getNodeFromTree(candidate, node);
 		}
 	});
 	return found;