Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a way to give deprecation warnings #1062

Closed
WilcoFiers opened this issue Aug 8, 2018 · 1 comment
Closed

Create a way to give deprecation warnings #1062

WilcoFiers opened this issue Aug 8, 2018 · 1 comment
Labels
core Issues in the core code (lib/core) help wanted We welcome PRs or discussions for issues marked as help wanted

Comments

@WilcoFiers
Copy link
Contributor

Currently the only option is to do axe.log() and give deprecation warnings that way. The problem with that is that those messages may not be exposed to the users in all situations, or worse, they may become part of the output stream and thus making it unappeasable. We need a standard solution that different integrations can opt into. Either make it part of the results object somehow, or have it be a callback you can pass into axe? I'm not sure about the solution yet, open to suggestions.

@WilcoFiers WilcoFiers added the core Issues in the core code (lib/core) label Aug 23, 2018
@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone Sep 11, 2019
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.0, axe-core 4.1 Apr 28, 2020
@straker straker added the help wanted We welcome PRs or discussions for issues marked as help wanted label Jul 29, 2020
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.1, axe-core 4.2 Sep 9, 2020
@WilcoFiers
Copy link
Contributor Author

We've largely deprecated use of custom evaluate / matches functions so this isn't as meaningful as it used to be. Tools have also gotten better about this, so IDEs can give these warnings for us. I don't think this ticket is important anymore.

@straker straker removed this from the axe-core 4.2 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) help wanted We welcome PRs or discussions for issues marked as help wanted
Projects
None yet
Development

No branches or pull requests

2 participants