Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid "int" attribute values not picked up (aria-posinset, aria-level, aria-colindex, aria-colspan, and aria-rowindex) #1288

Closed
schne324 opened this issue Dec 20, 2018 · 3 comments
Assignees
Labels
feat New feature or enhancement help wanted We welcome PRs or discussions for issues marked as help wanted rules Issue or false result from an axe-core rule

Comments

@schne324
Copy link
Member

Expectation: axe raises issue for attribute values less than 1 for the following attributes:

  • aria-posinset
  • aria-level
  • aria-colindex
  • aria-colspan
  • aria-rowindex

Actual: no issues are raised for the above attributes whose values are less than 1

Motivation: came across <div role="heading" aria-level="0" />

test page: https://xzoqr636po.codesandbox.io/
spec: for each of the above attributes the spec states:

The value for {attr name} is an integer greater than or equal to 1.

related files:


axe-core version: 3.1.1
axe-webdriver, extension or other integration version: 3.6.0
@schne324
Copy link
Member Author

I am happy to implement this if this is something everyone agrees should be added 😄

@WilcoFiers
Copy link
Contributor

I think this is a good idea. Feel free to create a PR.

@WilcoFiers WilcoFiers added feat New feature or enhancement rules Issue or false result from an axe-core rule labels Jan 4, 2019
@straker straker added the help wanted We welcome PRs or discussions for issues marked as help wanted label Jul 29, 2020
@straker straker self-assigned this Dec 21, 2020
@padmavemulapati
Copy link

Verified with the latest axe-core develop branch code:
validated for valid and invalid minValue for the following aria-attributes:

aria-posinset - minValue set as "1" , validated for 0,1
aria-posinset="0"
image
aria-posinset="1"
image

aria-level - minValue set as "1" , validated for 0,1
Pass criteria:(aria-level="1"
image
Fail criteria:(aria-level="0")
image
When aria-level=-1
image

@straker straker closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement help wanted We welcome PRs or discussions for issues marked as help wanted rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

4 participants