-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color-contrast): add px unit to error messages #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit should be marked as feat(color-contrast):
because this is a new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In my opinion this could read better as ${((fontSize * 72) / 96).toFixed(1)}pt (${fontSize}px)
Eg: 13.5pt (18px)
But that may be a personal preference.
@JKODU I did that first, but since we were already in an parenthesis group I didn't know if that would be OK
|
@straker, it is logical to express |
* fix(color-contrast): add px unit to error messages * change to show px in parenthesis
Add the size in px to the color contrast error message to avoid confusion with the pt unit.
Linked issue: #1628
Reviewer checks
Required fields, to be filled out by PR reviewer(s)