Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang query string to help URLs #1784

Closed
WilcoFiers opened this issue Aug 23, 2019 · 6 comments
Closed

Add lang query string to help URLs #1784

WilcoFiers opened this issue Aug 23, 2019 · 6 comments
Assignees
Labels
core Issues in the core code (lib/core) docs Documentation changes feat New feature or enhancement
Milestone

Comments

@WilcoFiers
Copy link
Contributor

To support DQU's localisation, axe-core's help URLs should include a language code, for example:

https://dequeuniversity.com/rules/axe/3.3/html-has-lang?lang=jp

This can be set when axe.configure() is called with a new locale.

@WilcoFiers WilcoFiers added feat New feature or enhancement core Issues in the core code (lib/core) labels Aug 23, 2019
@WilcoFiers WilcoFiers added this to the Axe-core 3.4 milestone Aug 23, 2019
@straker straker self-assigned this Aug 29, 2019
@jeankaplansky
Copy link
Contributor

@straker: This isn't a new rule, but is it something we should include in the release notes?

@jeankaplansky
Copy link
Contributor

Added to release notes 10/14/2019

@padmavemulapati
Copy link

padmavemulapati commented Oct 17, 2019

Verified this ticket, I am seeing the help URL, for language attribute is: https://dequeuniversity.com/rules/axe/3.3/html-has-lang?lang=ja (not lang=jp)
@WilcoFiers , can you please confirm that we are expecting "japanese" language , is n't it?
and from Dequeuniversity only two languages we can set and able to see the content into respective language.

@WilcoFiers
Copy link
Contributor Author

@straker found a bug in this. The lang attribute is not added in when you build axe using:

grunt build --lang=ja

@straker
Copy link
Contributor

straker commented Oct 18, 2019

Opened a separate issue #1861.

@padmavemulapati
Copy link

As this issue is tracking in #1861, closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) docs Documentation changes feat New feature or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants