Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locales): fix incompleteFallbackMessage to be a string rather than an object #1853

Merged
merged 6 commits into from
Oct 18, 2019
Merged

fix(locales): fix incompleteFallbackMessage to be a string rather than an object #1853

merged 6 commits into from
Oct 18, 2019

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Oct 17, 2019 •
edited by straker
Loading

Closes issue: #1810

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@michael-siek michael-siek requested a review from a team October 17, 2019 12:29
@michael-siek michael-siek added the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Oct 17, 2019
straker
straker approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested building a translation as well using grunt translate --lang=ko and it produced the correct structure in the output.

@straker straker changed the title fix(locale structure): structure message correctly when building translations fix(locales): fix incompeteMessageFallback to be a string rather than an object Oct 18, 2019
@straker
Copy link
Contributor

straker commented Oct 18, 2019

Note: change the PR title to better reflect what changed

@straker straker changed the title fix(locales): fix incompeteMessageFallback to be a string rather than an object fix(locales): fix incompleteFallbackMessage to be a string rather than an object Oct 18, 2019
@straker straker merged commit 88677a9 into develop Oct 18, 2019
@straker straker deleted the fix-issue-1810 branch October 18, 2019 16:14
straker added a commit that referenced this pull request Oct 18, 2019
@straker
Revert "fix(locales): fix incompeteMessageFallback to be a string rat…
486cfc8 
…her than an object (#1853)"

This reverts commit 88677a9.
straker pushed a commit that referenced this pull request Dec 11, 2019
@michael-siek @straker
fix(locales): fix incompeteMessageFallback to be a string rather than…
02a1d8a 
… an object (#1853)

* fix(aria-allowed-role): allow role combobox on input tel, search, url, and email

* fix(locale structure): structure message correct when building translations

* fix(possible merge conflict): revert the code to negate any merge conflicts

* fix(possible merge conflict): revert the code to negate any merge conflicts

* fix: ci failing due to prior commits

* fix: reverting files due to prior commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-siek @straker