fix(color-contrast): take into account parent opacity for foreground color #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Nov 18, 2019
WilcoFiers
approved these changes
Nov 18, 2019
straker
added a commit
that referenced
this pull request
Dec 11, 2019
…color (#1902) * fix(color-contrast): take into account parent opacity for foreground color * fix rounding errors * proper closeTo params * update * test recursive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our foreground color check did not take into account the parent opacity, so would incorrectly calculate the final color. Added a function that would gather the parent opacity level and cache it for quicker lookups.
Also did a quick performance optimization by passing the already calculated bgColor from the parent into the foreground color check so we didn't have to do that expensive operation again.
Closes issue: #1228
Reviewer checks
Required fields, to be filled out by PR reviewer(s)