-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider having a size budget for axe-core #1930
Comments
@straker I've put some of this in place already with the extension, so hit me up if you want to pair on this for axe-core. |
Dropped axe-core's filesize from 138kb in 4.0 to 108kb in 4.1! For 4.2 we should put tests in place to enforce a maximum size. |
Can we add a performance budget too? Some of the techniques for reducing size, may increase execution time. |
I like the idea of a performance budget. We'll probably want to separate our metrics into different size pages or buckets though as some rules perform worse on very large pages but this may be acceptable for the rule itself. |
From the discussion on GoogleChrome/lighthouse#10056, axe 3.4.0 added 60KB minified to our codebase, mostly from the addition of core-js Unit32Array polyfills needed for the ligature icon detection. This pushed lighthouse over their size budget, causing them to fail their build.
For 4.0.0 we should consider introducing a size budget ourselves so we don't continue to increase in size (as we have done as shown by @patrickhulce chart)
The text was updated successfully, but these errors were encountered: