fix(aria-hidden-focus): mark as needs review if a modal is open #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Jan 27, 2020
| } | ||
|
|
||
| axe._cache.set('isModalOpen', undefined); | ||
| return undefined; |
There was a problem hiding this comment.
Why is this returning true | undefined instead of just true | false?
There was a problem hiding this comment.
I thought about returning false but I didn't want it to seem like the test was accurate and could say "false" meant a modal was not open. Undefined kinda help make the check feel more uncertain that we're not even sure if a modal is open or not.
WilcoFiers
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule will now return as needs review if there are focusable elements present while what we believe to be a modal is open. On the react example, it will now return as needs review rather than failing when the modal is open that traps focus https://react-bootstrap.github.io/components/modal/#modals-live.
Closes issue: #1482
Reviewer checks
Required fields, to be filled out by PR reviewer(s)